Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCD peer discovery ignores TTL configuration #7554

Closed
mkuratczyk opened this issue Mar 9, 2023 · 0 comments · Fixed by #7589
Closed

ETCD peer discovery ignores TTL configuration #7554

mkuratczyk opened this issue Mar 9, 2023 · 0 comments · Fixed by #7589
Assignees
Labels
Milestone

Comments

@mkuratczyk
Copy link
Contributor

A bug introduced during the migration to etcd v3 API: TTL settings are read from the Settings map:

node_key_ttl_in_seconds = erlang:max(
?MINIMUM_NODE_KEY_LEASE_TTL,
maps:get(etcd_node_ttl, Settings, ?DEFAULT_NODE_KEY_LEASE_TTL)

But that map is constructed ignoring TTL options provided by the user:

maps:merge(maps:without([etcd_prefix, etcd_node_ttl, lock_wait_time], Map),

The end result is that the TTL settings cannot be configured and the default values are used.

originally reported on slack:
https://rabbitmq.slack.com/archives/C1EDN83PA/p1678330813982069

michaelklishin added a commit that referenced this issue Mar 10, 2023
@michaelklishin michaelklishin added this to the 3.11.11 milestone Mar 10, 2023
mergify bot pushed a commit that referenced this issue Mar 10, 2023
Closes #7554

(cherry picked from commit f27fa06)
mergify bot pushed a commit that referenced this issue Mar 10, 2023
Closes #7554

(cherry picked from commit f27fa06)
(cherry picked from commit 0a91bf1)
mergify bot pushed a commit that referenced this issue Mar 10, 2023
Closes #7554

(cherry picked from commit f27fa06)
(cherry picked from commit 0a91bf1)
(cherry picked from commit 7d8afae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants