Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq-server.ocf stop action returns before the rabbitmq processes have stopped #72

Closed
jmcmeek opened this issue Mar 16, 2015 · 3 comments
Assignees
Milestone

Comments

@jmcmeek
Copy link

jmcmeek commented Mar 16, 2015

When pacemaker attempts to restart rabbitmq and rabbbitmq is already running, the start request frequently fails. I found that the previous beam.smp process was still running when the resource agent attempted to start rabbitmq-server.

I saw that the initd script does a "rabbitmqctl stop ". Adding the pidfile parameter to the resource agent appears to fix this problem.

@michaelklishin
Copy link
Member

Sorry, this is not specific enough. Adding what exactly to what file? (feel free to submit a pull request, by the way)

@jmcmeek
Copy link
Author

jmcmeek commented Mar 16, 2015

This is in https://github.com/rabbitmq/rabbitmq-server/blob/master/packaging/common/rabbitmq-server.ocf
in rabbit_stop:

302 $RABBITMQ_CTL stop <= add $RABBITMQ_PID_FILE

When I get approval from our legal folks to do so, I can look at submitting a pull request.

@dumbbell
Copy link
Member

I think it's reasonable and would even be consistent with the init scripts from the RPM and Debian packages which already do this.

@dumbbell dumbbell self-assigned this Mar 25, 2015
dumbbell added a commit that referenced this issue Mar 25, 2015
@dumbbell dumbbell added this to the 3.5.1 milestone Mar 25, 2015
dumbbell added a commit that referenced this issue Mar 26, 2015
dcorbacho pushed a commit that referenced this issue May 27, 2016
Add a special value to term_to_json to allow encoding empty JSON objects
dcorbacho pushed a commit that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants