Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/usr/sbin/rabbitmqctl contains bash functionality while running sh #321

Closed
EmilienM opened this issue Sep 24, 2015 · 13 comments
Closed

/usr/sbin/rabbitmqctl contains bash functionality while running sh #321

EmilienM opened this issue Sep 24, 2015 · 13 comments

Comments

@EmilienM
Copy link

/usr/sbin/rabbitmqctl is running /bin/sh but contains bash functionality:
if [ $(uname -s) == "Linux" ]; then

Introduced by b82a9fd

It should be:
if [ $(uname -s) = "Linux" ]; then

Co-debugged with Denis Egorenko.

@degorenko
Copy link

rabbitmqctl -q list_users
/usr/sbin/rabbitmqctl: 19: [: Linux: unexpected operator
guest [administrator]

@EmilienM
Copy link
Author

It's actually fixed in master by 6964e8a
We might need a new release.

@degorenko
Copy link

No, 3.5.5 has this, but anyway broken.

@EmilienM
Copy link
Author

Right, we need a 3.5.6 as soon as possible.

@videlalvaro
Copy link
Contributor

My colleague @dumbbell is working on a fix for this.

@dumbbell
Copy link
Member

We are recreating the RPM and Debian packages with the script fixed. I will let you know when it's done.

@michaelklishin
Copy link
Member

We are looking at building a new package revision. Packages other than Debian and RPM are not affected. 3.5.4 is still available from Bintray and Package Cloud.

On 24 sept 2015, at 19:25, Emilien Macchi [email protected] wrote:

Right, we need a 3.5.6 as soon as possible.


Reply to this email directly or view it on GitHub.

@degorenko
Copy link

We need backport this:

67c24aa

@michaelklishin
Copy link
Member

Denis,

If you check the stable branch you would notice that we already did.

We appreciate how proactive you are but really, we are well aware of what needs to be done and why.

On 24 sept 2015, at 19:47, Denis Egorenko [email protected] wrote:

We need backport this:

67c24aa


Reply to this email directly or view it on GitHub.

@degorenko
Copy link

Michael,

Ok, thanks, just for information and bug log.

@dumbbell
Copy link
Member

The rerolled packages were delayed by #325. The new build is now in progress.

We are sorry for these two bugs. We really need to improve the testing of the Debian and RPM packages (the broken script is only used in those packages)...

@dumbbell dumbbell added this to the 3.5.5 milestone Sep 24, 2015
@dumbbell dumbbell self-assigned this Sep 24, 2015
openstack-gerrit pushed a commit to openstack/puppet-openstack-integration that referenced this issue Sep 24, 2015
RabbitMQ 3.5.5 has a bug [1] that prevent puppetlabs-rabbitmq module to
create permissions:

Could not evaluate: cannot parse line from
list_user_permissions:/usr/sbin/rabbitmqctl: 19: [: Linux: unexpected
operator]

This patch is a workaround to make sure we install the previous stable
version of RabbitMQ (3.5.4). Since puppetlabs-rabbitmq module will only
check if the package is 'installed', it won't try to update it.

[1] rabbitmq/rabbitmq-server#321

Change-Id: I8e0fa8e62e93b62317011fd7c8a2730cd293d4c7
@dumbbell
Copy link
Member

New packages (3.5.5-3) were uploaded. Thank you reporting the problem!

@EmilienM
Copy link
Author

Thank you guys for your responsiveness. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants