ANSI escape code characters should be avoided on Windows #2634
Comments
michaelklishin
changed the title
rabbitmqctl.bat output makes things harder to read
|
Hi |
|
It is not a priority right now as we are fairly busy with more impactful changes. A PR would be most welcome though. |
|
Ok, thanks for info. |
|
Making all functions in this module to return values as is on Windows should be all there is to do. |
ariel-anieli
added a commit
to ariel-anieli/rabbitmq-server
that referenced
this issue
Jan 9, 2024
ariel-anieli
added a commit
to ariel-anieli/rabbitmq-server
that referenced
this issue
Jan 9, 2024
12 tasks
michaelklishin
added a commit
that referenced
this issue
Jan 10, 2024
#2634 - if ASCII disabled, remove escape codes
mergify bot
pushed a commit
that referenced
this issue
Jan 10, 2024
https://hexdocs.pm/elixir/IO.ANSI.html#format/2 (cherry picked from commit 09b4be9)
michaelklishin
pushed a commit
that referenced
this issue
Jan 31, 2024
michaelklishin
pushed a commit
that referenced
this issue
Feb 1, 2024
michaelklishin
pushed a commit
that referenced
this issue
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example,
Help:gets printed as�[1mHelp�[0m:.This is because we are attempting to print "Help:" in bold via ANSI escape codes, which don't appear to be supported on Windows (at least for common configurations).
Apparently the necessary APIs to properly detect support for these codes isn't provided by Erlang, so my suggestion would be that we fall back to unformatted output when running on Windows.
The text was updated successfully, but these errors were encountered: