You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
by protocol, I could create a super stream with the same partitions name:
conststringSuperStream="my_super_stream_with_2_partitions";varpartitions=newList<string>{"partition_0","partition_0"};//// <---- partition names are equals varbindingKeys=newList<string>(){"0","1"};varargs=newDictionary<string,string>{{"queue-leader-locator","least-leaders"},{"max-length-bytes","10000"},{"max-age","30000s"}};varresponse=awaitclient.CreateSuperStream(SuperStream,partitions,bindingKeys,args);Assert.Equal(ResponseCode.Ok,response.ResponseCode);
In this case, the server error side is :
2024-02-12 10:16:51.981857+00:00 [warning] <0.970.0> Error while trying to create super stream <<"my_super_stream_with_2_partitions">>: reference_already_exists
That is not correct since my_super_stream_with_2_partitions does not exist.
Do you think we can improve the server-side log with something like the following:
<0.970.0> Error while trying to create super stream <<"my_super_stream_with_2_partitions">> the partition `partition_0` _already_exists
The error sent back is internalError, which seems scary.
I would send a precondition failure
Reproduction steps
Create a super stream with two partitions with the same name.
Expected behavior
Change the server-side log.
Change the error returned to precondition failure
Additional context
No response
The text was updated successfully, but these errors were encountered:
michaelklishin
changed the title
[SuperStream] Improve the error message when fail to create a super stream
Improve the error message when fail to create a super stream
Feb 12, 2024
Describe the bug
by protocol, I could create a super stream with the same partitions name:
In this case, the server error side is :
That is not correct since
my_super_stream_with_2_partitions
does not exist.Do you think we can improve the server-side log with something like the following:
The error sent back is
internalError
, which seems scary.I would send a
precondition failure
Reproduction steps
Create a super stream with two partitions with the same name.
Expected behavior
Change the server-side log.
Change the error returned to
precondition failure
Additional context
No response
The text was updated successfully, but these errors were encountered: