-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP API request to /api/nodes/{node_name}
where {node_name}
isn't a valid RabbitMQ node fails with 500 error.
#10330
Comments
ikavgo
pushed a commit
that referenced
this issue
Jan 25, 2024
Closed
12 tasks
michaelklishin
added a commit
that referenced
this issue
Jan 31, 2024
michaelklishin
added a commit
that referenced
this issue
Feb 1, 2024
michaelklishin
added a commit
that referenced
this issue
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
HTTP API request to
/api/nodes/{node_name}
where{node_name}
isn't a valid RabbitMQ node fails with 500 error.A 404 would be a more appropriate response.
Reproduction steps
curl -v http://localhost:15672/api/nodes/NOTANODENAME'
...
Expected behavior
404 would be the expected response when a resource does not exist.
Additional context
rabbitmq-server/deps/rabbitmq_management/src/rabbit_mgmt_wm_node.erl
Lines 74 to 78 in 9ff387e
This function does not handle unknown node names correction, however the intire
resouce_exist
callback impl could be substantially optimised by just checking the the node is inrabbit_nodes:list_members/0
The text was updated successfully, but these errors were encountered: