Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Hard-coded use of "make" in the testsuite #23

Closed
dumbbell opened this issue May 6, 2015 · 0 comments
Closed

Hard-coded use of "make" in the testsuite #23

dumbbell opened this issue May 6, 2015 · 0 comments
Assignees
@dumbbell
Labels
bug effort-tiny
Milestone
3.5.2

Comments

@dumbbell
Copy link
Member

dumbbell commented May 6, 2015

The testsuite assumes make is GNU make which may not be the case. For instance, this prevents the usage of the testsuite on FreeBSD.

The value of $MAKE should be passed down to the test.
@dumbbell dumbbell self-assigned this May 6, 2015
@dumbbell dumbbell added this to the 3.5.2 milestone May 6, 2015
dumbbell added a commit to rabbitmq/rabbitmq-public-umbrella that referenced this issue May 6, 2015
@dumbbell
do-package.mk: Pass $(MAKE) down to test environments
549867e 
This is required so test scripts do not need to hard-code "make".

References rabbitmq/rabbitmq-mqtt#23.
References rabbitmq/rabbitmq-delayed-message-exchange#4.
dumbbell added a commit that referenced this issue May 7, 2015
@dumbbell
test/Makefile: Use $MAKE instead of hard-coding "make"
b2d0810 
This one was harmless but let's do this for consistency's sake.

References #23.
limhyungseok added a commit to limhyungseok/rabbitmq-mqtt that referenced this issue May 11, 2016
@limhyungseok
Merge pull request rabbitmq#23 from limhyungseok/master
6dcc0a8 
Merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dumbbell dumbbell

Labels
bug effort-tiny
Projects
None yet
Milestone
3.5.2
Development

No branches or pull requests
1 participant
@dumbbell