Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Gracefully close connections to non-existent virtual hosts #100

Closed
michaelklishin opened this issue Sep 8, 2016 · 0 comments
Closed

Gracefully close connections to non-existent virtual hosts #100

michaelklishin opened this issue Sep 8, 2016 · 0 comments
Assignees
@acogoluegnes
Labels
effort-tiny usability
Milestone
3.6.7

Comments

@michaelklishin
Copy link
Member

michaelklishin commented Sep 8, 2016 •
edited
Loading

See #99. When a vhost doesn't exit, e.g. because a colon is unknowingly used in a username, MQTT connections should be closed immediately in a more reasonable way (of course, ideally we would want to issue an authentication failure notification or similar but client error notification in MQTT is still in the stone age).
@michaelklishin michaelklishin modified the milestone: 3.7.0 Dec 1, 2016
@acogoluegnes acogoluegnes added this to the 3.6.7 milestone Dec 6, 2016
acogoluegnes added a commit that referenced this issue Dec 6, 2016
@acogoluegnes
Gracefully close connections to non-existent virtual hosts
ae720d0 
Return CONNACK 4 code when the virtual host doesn't exist.
The MQTT description for this return code states "The data in
the user name or password is malformed", which not exactly
accurate but better than a pending or abruptly closed connection.
The server logs also a more meaningful message.

Fixes #100
@acogoluegnes acogoluegnes mentioned this issue Dec 6, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@acogoluegnes acogoluegnes

Labels
effort-tiny usability
Projects
None yet
Milestone
3.6.7
Development

No branches or pull requests
2 participants
@michaelklishin @acogoluegnes