Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQConnection missing "/" for non-default virtual hosts #42

Closed
dharrigan opened this issue Apr 22, 2015 · 3 comments
Closed

AMQConnection missing "/" for non-default virtual hosts #42

dharrigan opened this issue Apr 22, 2015 · 3 comments
Assignees
@michaelklishin
Labels
bug effort-tiny usability
Milestone
3.5.2

Comments

@dharrigan
Copy link
Contributor

Hi,

In AMQConnection, line 865, if the virtualHost, is not the default, the resultant toString looks something like this:

amqp://[email protected]:5672test

It should be

amqp://[email protected]:5672/test

PR coming shortly.

-=david=-
michaelklishin added a commit that referenced this issue Apr 22, 2015
@michaelklishin
Merge pull request #44 from dharrigan/stable
c5cb829 
Issue #42: AMQConnection missing "/" for non-default virtual hosts.
@michaelklishin michaelklishin added this to the 3.5.2 milestone Apr 22, 2015
@michaelklishin michaelklishin self-assigned this Apr 22, 2015
@michaelklishin
Copy link
Member

Fixed by #44. Thank you, @dharrigan!

@dharrigan
Copy link
Contributor Author

np :)

@dumbbell
Copy link
Member

Since RabbitMQ 1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
bug effort-tiny usability
Projects
None yet
Milestone
3.5.2
Development

No branches or pull requests
3 participants
@michaelklishin @dumbbell @dharrigan