This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Make Federation connections (links) specify a name #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test failed, but it looks like it was a transient failure. |
michaelklishin
suggested changes
Oct 19, 2016
| connection_name(undefined, undefined). | ||
|
|
||
| connection_name(Upstream, Policy) when is_binary(Upstream), is_binary(Policy) -> | ||
| <<<<"Federation ">>/binary, Upstream/binary, <<" ">>/binary, Policy/binary>>; |
There was a problem hiding this comment.
Please make it "Federation link (upstream: …, policy: …)".
| <<<<"Federation ">>/binary, Upstream/binary, <<" ">>/binary, Policy/binary>>; | ||
|
|
||
| connection_name(_, _) -> | ||
| <<"Federation">>. |
There was a problem hiding this comment.
"Federation link" would be clearer.
There was a problem hiding this comment.
Done. Looks like this now:
| {ok, Conn, Ch} -> erlang:monitor(process, Ch), | ||
| {ok, Conn, Ch}; | ||
| E -> E | ||
| end. | ||
|
|
||
| open(Params) -> | ||
| case amqp_connection:start(Params) of | ||
| open(Params, Source) -> |
There was a problem hiding this comment.
The parameter seems to be a name, not a source.
michaelklishin
approved these changes
Oct 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection name pattern is
Federation [Upstream name] [Policy name].Fixes #39