Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Use Ranch for TCP acceptor pool #22

Merged
merged 3 commits into from
Nov 19, 2015
Merged

Conversation

essen
Copy link
Contributor

@essen essen commented Nov 10, 2015

Part of rabbitmq/rabbitmq-server#260.

This change is necessary because the ssl_socket record is gone.

@michaelklishin
Copy link
Member

After merging master in, make tests fails with

BOOT FAILED
===========

Error description:
   {could_not_start,rabbit,
       {{case_clause,
            {error,
                {{undef,
                     [{ranch,child_spec,
                          [{acceptor,{0,0,0,0,0,0,0,0},5672},
                           1,ranch_tcp,
                           [{port,5672},
                            {ip,{0,0,0,0,0,0,0,0}},
                            {max_connections,infinity},
                            {ack_timeout,5000},
                            {connection_type,supervisor},
                            inet6,binary,
                            {backlog,128},
                            {nodelay,true},
                            {linger,{true,0}},
                            {exit_on_close,false},
                            {active,false},
                            {packet,raw},
                            {reuseaddr,true}],
                           rabbit_connection_sup,[]],
                          []},
                      {tcp_listener_sup,init,1,
                          [{file,"src/tcp_listener_sup.erl"},{line,59}]},
                      {supervisor,init,1,[{file,"supervisor.erl"},{line,272}]},
                      {gen_server,init_it,6,
                          [{file,"gen_server.erl"},{line,328}]},
                      {proc_lib,init_p_do_apply,3,
                          [{file,"proc_lib.erl"},{line,240}]}]},
                 {child,undefined,'rabbit_tcp_listener_sup_:::5672',
                     {tcp_listener_sup,start_link,
                         [{0,0,0,0,0,0,0,0},
                          5672,ranch_tcp,
                          [inet6,binary,
                           {backlog,128},
                           {nodelay,true},
                           {linger,{true,0}},
                           {exit_on_close,false},
                           {active,false},
                           {packet,raw},
                           {reuseaddr,true}],
                          rabbit_connection_sup,[],
                          {rabbit_networking,tcp_listener_started,[amqp]},
                          {rabbit_networking,tcp_listener_stopped,[amqp]},
                          "TCP Listener"]},
                     transient,infinity,supervisor,
                     [tcp_listener_sup]}}}},
        [{rabbit_networking,start_listener0,4,
             [{file,"src/rabbit_networking.erl"},{line,305}]},
         {rabbit_networking,'-start_listener/4-lc$^0/1-0-',4,
             [{file,"src/rabbit_networking.erl"},{line,294}]},
         {rabbit_networking,start_listener,4,
             [{file,"src/rabbit_networking.erl"},{line,294}]},
         {rabbit_networking,'-boot_tcp/0-lc$^0/1-0-',1,
             [{file,"src/rabbit_networking.erl"},{line,125}]},
         {rabbit_networking,boot_tcp,0,
             [{file,"src/rabbit_networking.erl"},{line,125}]},
         {rabbit_networking,boot,0,
             [{file,"src/rabbit_networking.erl"},{line,120}]},
         {rabbit_boot_steps,'-run_step/2-lc$^1/1-1-',1,
             [{file,"src/rabbit_boot_steps.erl"},{line,49}]},
         {rabbit_boot_steps,run_step,2,
             [{file,"src/rabbit_boot_steps.erl"},{line,49}]}]}}

deps/ranch is at c0566d4d986b9d143a7b066f52383652da5f7f74.

@michaelklishin michaelklishin self-assigned this Nov 14, 2015
@michaelklishin michaelklishin added this to the n/a milestone Nov 14, 2015
@michaelklishin
Copy link
Member

The same happens for other sub-projects, so I may have an outdated dependency somewhere else.

@essen
Copy link
Contributor Author

essen commented Nov 14, 2015

I mentioned this to @dumbbell, try with ERL_LIBS=.. make tests for now.

@michaelklishin
Copy link
Member

Thanks, all tests pass.

@michaelklishin michaelklishin changed the title DO NOT MERGE WIP: First steps to moving RabbitMQ to Ranch DO NOT MERGE: Use Ranch for TCP acceptor pool Nov 14, 2015
@essen essen force-pushed the rabbitmq-server-260 branch from a9f5303 to 613b65f Compare November 17, 2015 14:43
@essen
Copy link
Contributor Author

essen commented Nov 17, 2015

Rebased and updated the commit title.

@essen essen changed the title DO NOT MERGE: Use Ranch for TCP acceptor pool Use Ranch for TCP acceptor pool Nov 17, 2015
@michaelklishin
Copy link
Member

Testing GH notifications.

michaelklishin added a commit that referenced this pull request Nov 19, 2015
@michaelklishin michaelklishin merged commit 6b4ec7f into master Nov 19, 2015
@dumbbell dumbbell deleted the rabbitmq-server-260 branch January 2, 2018 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants