Revert client authentication changes in 36efc00 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2015 18:34
This change broke SSL version checking. This reverts commit 36efc00.
|
This makes it impossible (again) to not provide a client certificate. I suspect we should provide an empty |
michaelklishin
changed the title
|
Thank you. I had to add a couple of |
|
Commits fixing this issue were cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in 36efc00 broke the client's ability to require specific version(s) of SSL. This pull request contains a test that fails when the feature is broken, and a revert commit to fix it.
This seems to work correctly whether I am presenting a client certificate or not. I can't speak for Mono, but everything works fine this way on Windows.