Use Microsoft.CodeAnalysis.PublicApiAnalyzers
#1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1269
branch
from
59d86ae to
1fa2325
Compare
Reference: #1269 * Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library. * Remove existing APIApproval tests. Replaced by PublicApiAnalyzers. * Add retries when connection can't be open due to a `SocketException`. * Change Windows GitHub actions runner to windows-2019. It should be faster and may not have that socket exception * Add connection retries for SocketException to SSL tests. Uncovered with windows 2019.
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1269
branch
from
1fa2325 to
a0511ad
Compare
lukebakken
added a commit
that referenced
this pull request
Dec 20, 2023
Follow-up to #1447 Ensure CreateConnectionFactory is used so that client name is provided Look for either of two exceptions
lukebakken
added a commit
that referenced
this pull request
Dec 20, 2023
Follow-up to #1447 Ensure CreateConnectionFactory is used so that client name is provided Look for either of two exceptions
lukebakken
added a commit
that referenced
this pull request
Dec 20, 2023
Follow-up to #1447 Ensure CreateConnectionFactory is used so that client name is provided Look for either of two exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1269
Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library.