Implement AMQP filter expressions #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-amqp-dotnet-client-80
branch
from
46bcf1c to
9f64013
Compare
lukebakken
force-pushed
the
rabbitmq-amqp-dotnet-client-80
branch
from
9fe3f15 to
f266a0f
Compare
Gsantomaggio
reviewed
Nov 6, 2024
There was a problem hiding this comment.
We'd need to support RabbitMQ versions 4.0 and 4.1 based on properties.
Like https://github.com/rabbitmq/rabbitmq-amqp-dotnet-client/pull/81/files#diff-6ae5ff33a31c0e120fe02d2748cee1efcc6f9c9d374c56dc48a1aa84c363b5c5R129
|
@Gsantomaggio if we don't want a dependency on Update: yeah, I'll do that. |
* Start by refactoring a couple tests that use `ManualResetEvent` for coordination. * Correctly set stream filter AMQP types in the filters map. * Comment-out extra logging * Replace `ManualResetEvent` with `AsyncManualResetEvent` * Add `IStreamFilterOptions` * Port code documentation from Java client * Add more docs from Java client. * Add `IStreamFilterOptions` member functions. * Begin porting `filterExpressionApplicationProperties` test from the Java client. * Use `pivotalrabbitmq/rabbitmq:main` because it supports AMQP 1.0 filters * Add overloads for specific types for MessageId and CorrelationId * Just settle on `object` for Message ID and Correlation ID * Implement the rest of the message properties in `IMessage`. * Rename `ApplicationProperties` to `Properties` to match Java client. * `StreamConsumerFilterExpressionApplicationProperties` test runs successfully. * Finish `StreamConsumerFilterExpressionApplicationProperties` test. * Port `streamFiltering` test from Java client. * Bump testing Windows versions * Add `Semver` package to Tests project to allow parsing broker version. * Skip stream filtering tests (on properties) if not at least RabbitMQ 4.1.0 * Change `IConnection` API to use `IEnumerable` instead of `ReadOnlyCollection` * Add some messaging for when the StreamFilter test comparison fails. * Fix the `StreamFilter` test. * Validate message annotation key to ensure they start with `x-` * Validate the string overload for specifying a stream offset. * Port `StreamConsumerOptionsOffsetInterval` test from Java client. * Port `StreamConsumerOptionsOffsetNext` from Java client. * Port `StreamConsumerOptionsOffsetLong` from Java client. * Working on `FilterExpressionProperties` * Finish port of `FilterExpressionProperties` test. * Link operations Accept, Requeue, Discard can't be async * Continue working on `FilterExpressionPropertiesAndApplicationProperties` test * Remove `Thread.Sleep` * Finish `FilterExpressionPropertiesAndApplicationProperties` test. * Remove dupicated code around validating message annotation key * Move code out of `Utils` that is only used for tests * Finish porting last two tests from `SourceFiltersTest.java` * Remove `AmqpConnection` from `ConsumerConfiguration`. * Add TODO to detect RMQ version when stream filters are used. * Add TLS callback fot the tests * Add arm build for the docker image * Parse broker version and set filter capabilities based on it. Signed-off-by: Gabriele Santomaggio <[email protected]>
lukebakken
force-pushed
the
rabbitmq-amqp-dotnet-client-80
branch
from
d54e8fa to
b96375e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80