khepri_export_erlang: Accept atoms and binaries as filenames #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] The `file:name_all()` type accepts atoms and binaries in its definition. Also, Elixir strings are binaries really, so using `"filename.erl"` as the filename would break because the module would consider that binary filename as an already opened file descriptor. [How] The guard expression is expanded to accept atoms and binaries. Fixes #278.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 89.36% 89.33% -0.04%
==========================================
Files 21 21
Lines 3084 3084
==========================================
- Hits 2756 2755 -1
- Misses 328 329 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
deleted the
consider-binary-to-be-filename-in-khepri_export_erlang
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
file:name_all()type accepts atoms and binaries in its definition.Also, Elixir strings are binaries really, so using
"filename.erl"as the filename would break because the module would consider that binary filename as an already opened file descriptor.How
The guard expression is expanded to accept atoms and binaries.
Fixes #278.