Automatically clean the list of running stores if a Ra server has stopped behind the scene #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] If a Ra server has stopped behind the back of Khepri, we want to delete it from the list of running stores. [How] Instead of having an assertion to ensure that the presence or absence of a store in the list of running stores matches the result of `is_store_running/1`, we clean up the list if needed as part of that function.
[Why] If a Ra server has stopped behind the back of Khepri, the cached list of running stores might not reflect the reality. [How] We filter the cached list using `is_store_running/1`. This function will clean up the list as a side effect too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 89.37% 89.39% +0.02%
==========================================
Files 21 21
Lines 3078 3084 +6
==========================================
+ Hits 2751 2757 +6
Misses 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
force-pushed
the
auto-cleanup-store-ids-list
branch
from
f165e51 to
aabaa5a
Compare
…crashed Ra servers [Why] These functions didn't use to handle a Ra server that has stopped behing the back of Khepri correctly. This is fixed by the two previous commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If a Ra server has stopped behind the back of Khepri, the
is_store_running/1andget_store_ids/0function will return incorrect data or even hit an assertion.How
With these commits, the list is automatically cleaned up if one of the functions detects that a stopped Ra server is still listed.
Fixes #271.