Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "keep until" conditions to "keep while" conditions #18

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Rename "keep until" conditions to "keep while" conditions #18

merged 1 commit into from
Dec 8, 2021

Conversation

dumbbell
Copy link
Member

@dumbbell dumbbell commented Dec 8, 2021

The reason is that we want to "keep a node while a condition remains true". It is clearer than "keep a node until a condition becomes false" which was my initial thinking.

@dumbbell
Rename "keep until" conditions to "keep while" conditions
54fd53e 
The reason is that we want to "keep a node while a condition remains
true". It is clearer than "keep a node until a condition becomes false"
which was my initial thinking.
@dumbbell dumbbell self-assigned this Dec 8, 2021
@coveralls
Copy link

coveralls commented Dec 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 174

  • 40 of 41 (97.56%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 81.329%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/khepri_machine.erl 37 38 97.37%
Files with Coverage Reduction New Missed Lines %
src/khepri_machine.erl 3 90.24%
Totals Coverage Status
Change from base Build 172: 0.0%
Covered Lines: 1224
Relevant Lines: 1505
💛 - Coveralls

@dumbbell dumbbell marked this pull request as ready for review December 8, 2021 13:36
@dumbbell dumbbell merged commit 7c5e3de into main Dec 8, 2021
@dumbbell dumbbell deleted the rename-keep_until-to-keep_while branch December 8, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dumbbell dumbbell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dumbbell @coveralls