Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accent phrase border in pp_symbols #26

Closed
sucveria opened this issue Oct 27, 2021 · 2 comments · Fixed by #29
Closed

Fix accent phrase border in pp_symbols #26

sucveria opened this issue Oct 27, 2021 · 2 comments · Fixed by #29
Assignees
Labels
bug Something isn't working

Comments

@sucveria
Copy link

openjtalk.pyのpp_symbolsにおいて、151行目のアクセント句境界の条件が
if a3 == 1 and a2_next == 1:
となっており、子音と母音の区別がないため、子音と母音の間にも区切り記号'#'が入ってしまいます。
条件に当該音素が母音、撥音、促音に該当する場合を追加して、
if a3 == 1 and a2_next == 1 and p3 in "aeiouAEIOUNcl":
とすべきではないでしょうか。
(現実的には促音の後に区切りが入ることはないかもしれませんが)

r9y9 added a commit that referenced this issue Dec 5, 2021
r9y9 added a commit that referenced this issue Dec 5, 2021
to prevent future regressions

ref #26
@r9y9
Copy link
Owner

r9y9 commented Dec 5, 2021

対応が遅くなってしまい誠に申し訳ございません。ご指摘の通りで正しいです。提案していただいた修正を #29 で行い、また単体テストを追加しました。

@r9y9 r9y9 self-assigned this Dec 5, 2021
@r9y9 r9y9 added the bug Something isn't working label Dec 5, 2021
@r9y9 r9y9 closed this as completed in #29 Dec 6, 2021
@r9y9
Copy link
Owner

r9y9 commented Dec 6, 2021

https://docs.google.com/spreadsheets/d/185pTXTzCI3l4kkJTXVa4fsu6yhAwd8aury2PnLol55Q/edit?usp=sharing 正誤表をアップデートしました。 #29 をマージしました。こちらのイシューはクローズとさせていただきます。ご指摘ありがとうございました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants