Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility issues under Xcode 15.0 #9

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Conversation

Magic-Xin
Copy link
Contributor

Fixed compatibility issues under Xcode 15.0 which seems caused by C++17 standard.

@FunJim
Copy link

FunJim commented Feb 4, 2024

Could someone review this PR? Currently pyopenjtalk build is failed on macOS Sonoma (see r9y9/pyopenjtalk#75)

@r9y9
Copy link
Owner

r9y9 commented Feb 8, 2024

I am sorry that I was unable to check this PR. I will try to make some time in this weekend to look into this issue

@w568w
Copy link

w568w commented Jul 9, 2024

Bump. @r9y9, do you have time to review this now?

This is a simple PR that removes the deprecated and now invalid register keywords from src/mecab.

It seems the original author intended to improve performance with register, but compilers have ignored this keyword for a long time. Removing it won't affect the final binary, thus this PR is purely a clean-up, eliminating an outdated and ineffective part of the code!

Rationale: Clang 18.1.8 has already removed support for register and treats it as an error. GCC 14.1.1 is slightly more tolerant but will also stop supporting it very soon.

@r9y9
Copy link
Owner

r9y9 commented Jul 13, 2024

I apologize for the super delay. I checked this PR works OK with clang 18

clang version 18.1.8 (https://github.com/llvm/llvm-project.git 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
Target: arm64-apple-darwin22.6.0
Thread model: posix

@r9y9 r9y9 merged commit 7b8e3df into r9y9:1.11 Jul 13, 2024
@r9y9
Copy link
Owner

r9y9 commented Jul 13, 2024

Thank you very much, @Magic-Xin and @w568w

r9y9 added a commit to r9y9/pyopenjtalk that referenced this pull request Jul 13, 2024
tsukumijima pushed a commit to tsukumijima/open_jtalk that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants