Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't render content as title in callouts with empty titled paragraph #150

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

r4ai
Copy link
Owner

@r4ai r4ai commented Jul 31, 2024

fix #116

Fixed an issue where the body was displayed as the title in callouts with a title consisting only of line breaks.

Example:

> [!IMPORTANT]  
> Crucial information necessary for users to succeed.

yields:

<div data-callout data-callout-type="important">
  <div data-callout-title>Important<br>
  </div>
  <div data-callout-body>
    <p>Crucial information necessary for users to succeed.</p>
  </div>
</div>

@r4ai r4ai added the bug Something isn't working label Jul 31, 2024
@r4ai r4ai self-assigned this Jul 31, 2024
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 2effedc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@r4ai/remark-callout Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@r4ai r4ai enabled auto-merge (squash) July 31, 2024 09:17
@r4ai r4ai merged commit 156f660 into main Jul 31, 2024
3 checks passed
@r4ai r4ai deleted the feature/issue-116 branch July 31, 2024 09:17
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty titled paragraph renders content in title
1 participant