Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tui] update ColorWheel to replace Gradient with something else #162

Closed
3 tasks done
nazmulidris opened this issue Oct 14, 2023 · 0 comments · Fixed by #173
Closed
3 tasks done

[tui] update ColorWheel to replace Gradient with something else #162

nazmulidris opened this issue Oct 14, 2023 · 0 comments · Fixed by #173
Labels
hacktoberfest help wanted Extra attention is needed

Comments

@nazmulidris
Copy link
Member

nazmulidris commented Oct 14, 2023 •
edited
Loading

In this file

https://github.com/r3bl-org/r3bl_rs_utils/blob/main/tui/src/tui/color_wheel/color_wheel_struct.rs#L320

we use Gradient.

The latest release of this crate removes this:

Replace it with B-spline interpolation

While in here, do an audit of

  • How does r3bl_ansi_color crate get used in r3bl_tui "properly"? Is there too much overlap between the two?
  • How is the detect terminal color and color support used between these two crates? Are there ways to streamline this? Eg: get rid of some strange NotSet variant in color support?
  • Clean up color conversion (consolidate this to use r3bl_ansi_color only)
@nazmulidris nazmulidris added help wanted Extra attention is needed hacktoberfest labels Oct 14, 2023
@nazmulidris nazmulidris mentioned this issue Oct 21, 2023
Closed
nazmulidris added a commit that referenced this issue Oct 22, 2023
@nazmulidris
[tui] Clean up color conversion
3a8069b 
Replace duplicate ways of color conversions and terminal capability
detection, standardizing on using r3bl_ansi_color.

Related issue: #162
nazmulidris added a commit that referenced this issue Oct 22, 2023
@nazmulidris
[tui] Drop palette crate, and use colorgrad instead
e202cc8 
palette crate dropped support for Gradient in the latest release
which prevented its latest version to be used. So dropping it here
in favor of the colorgrad crate.

Fixes: #162
@nazmulidris nazmulidris mentioned this issue Oct 22, 2023
Merged
nazmulidris added a commit that referenced this issue Oct 22, 2023
@nazmulidris
[tui] Clean up color conversion
5736f74 
Replace duplicate ways of color conversions and terminal capability
detection, standardizing on using r3bl_ansi_color.

Related issue: #162
nazmulidris added a commit that referenced this issue Oct 22, 2023
@nazmulidris
[tui] Drop palette crate, and use colorgrad instead
3c74879 
palette crate dropped support for Gradient in the latest release
which prevented its latest version to be used. So dropping it here
in favor of the colorgrad crate.

Fixes: #162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nazmulidris/cleanup-colors r3bl-org/r3bl-open-core
1 participant
@nazmulidris