refactor(mainnet): use genesis presets for mainnet runtime. #473

al3mart · 2025-02-17T17:17:45Z

Based on #472

Moves genesis configuration for mainnet into the runtime.

These are the different spec that will use the mainnet runtime. These are the ones we can pass to the node via --chain <spec>.

/// A development chain running on a single node, using the `mainnet` runtime.
pub const MAINNET_DEV: &str = "pop-dev";
/// Configures a local chain running on multiple nodes for testing purposes, using the `mainnet`
/// runtime.
pub const MAINNET_LOCAL: &str = "pop-local";
/// A live chain running on multiple nodes, using the `mainnet` runtime.
pub const MAINNET: &str = "pop";

Requirements:

Council seats are populated in genesis state

[sc-2373]

codecov-commenter · 2025-02-18T14:46:16Z

Codecov Report

Attention: Patch coverage is 96.13971% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (2f47e84) to head (7d80362).
Report is 4 commits behind head on al3mart/refactor-genesis-preset-testnet.

Files with missing lines	Patch %	Lines
runtime/mainnet/src/genesis.rs	96.62%	15 Missing ⚠️
node/src/command.rs	0.00%	4 Missing ⚠️
runtime/mainnet/src/apis.rs	0.00%	2 Missing ⚠️

@@                             Coverage Diff                             @@
##           al3mart/refactor-genesis-preset-testnet     #473      +/-   ##
===========================================================================
+ Coverage                                    76.18%   77.38%   +1.19%     
===========================================================================
  Files                                           92       93       +1     
  Lines                                        18354    18758     +404     
  Branches                                     18354    18758     +404     
===========================================================================
+ Hits                                         13983    14515     +532     
+ Misses                                        4105     3977     -128     
  Partials                                       266      266

Files with missing lines	Coverage Δ
node/src/chain_spec.rs	`65.73% <100.00%> (+52.36%)`	⬆️
runtime/mainnet/src/lib.rs	`66.23% <ø> (ø)`
runtime/mainnet/src/apis.rs	`0.00% <0.00%> (ø)`
node/src/command.rs	`0.00% <0.00%> (ø)`
runtime/mainnet/src/genesis.rs	`96.62% <96.62%> (ø)`

... and 2 files with indirect coverage changes

Daanvdplas

Well done, left some comments.

This PR is heavily correlated with the launch of devnet and testnet. Would be nice to hear what the plan is in terms of updating keys etc.

runtime/mainnet/src/genesis.rs

peterwht

Left a few nits, should be close to approving

runtime/mainnet/src/genesis.rs

peterwht · 2025-02-19T20:25:59Z

runtime/mainnet/src/genesis.rs

+	endowed_accounts.push(MaintenanceAccount::get());
+	endowed_accounts.push(PotId::get().into_account_truncating());
+	endowed_accounts.push(TreasuryAccount::get());


Thoughts on giving these accounts only ED?

peterwht · 2025-02-19T20:29:23Z

runtime/mainnet/src/genesis.rs

+		vec![GenesisAsset {
+			id: 0,
+			owner: Keyring::Alice.to_account_id(),
+			is_sufficient: false,
+			min_balance: ExistentialDeposit::get(),
+			name: "DOT".into(),
+			symbol: "DOT".into(),
+			decimals: 10,
+		}],


I realize you are getting conflicting code direction. However, for mainnet I would like to exclude this.

I am still not sold that we should have devs use the fungibles API for DOT. It introduces complexity (and potentially bad DevEx) due to pallet-balances missing functionality that pallet-assets has.

By including, we can forget its there. By excluding, we have to consciously add it in -- when we confirm it works.

If we want to reserve asset id 0, I recommend using another name than "DOT" as a placeholder.

Happy to remove from mainnet.

peterwht · 2025-02-19T20:30:33Z

runtime/mainnet/src/genesis.rs

+	let mut endowed_accounts = dev_accounts();
+	endowed_accounts.push(MaintenanceAccount::get());
+	endowed_accounts.push(PotId::get().into_account_truncating());
+	endowed_accounts.push(SudoAddress::get());


SudoAddress is a multisig, right? That would mean for the local_config we wouldn't be able to use Sudo.

This also means there is a flaw in the test

peterwht · 2025-02-19T20:31:15Z

runtime/mainnet/src/genesis.rs

+		vec![GenesisAsset {
+			id: 0,
+			owner: SudoAddress::get(),
+			is_sufficient: false,
+			min_balance: ExistentialDeposit::get(),
+			name: "DOT".into(),
+			symbol: "DOT".into(),
+			decimals: 10,
+		}],


Similarly, (for mainnet only) please remove or change the name from "DOT"

peterwht · 2025-02-19T20:33:29Z

runtime/mainnet/src/genesis.rs

+	})
+}
+
+// The initial balances at genesis.


Suggested change

// The initial balances at genesis.

// The initial balances at genesis for local testing only.

might consider adding this as well.

runtime/mainnet/src/genesis.rs

al3mart · 2025-02-20T08:52:11Z

Endowments have been improved in: 1ea9626

Such that only dev accounts get ENDOWMENT amount and all the rest are only funded with ED.
While it might have been handy to keep sudo mutlisig with more funds than ED, we can easily override this in the zombienet spec. The SS58 account is provided in a test for easy access.

No assets are stores at genesis anymore: 57f4d96.
The asset key however remain in genesis empty, as we have seen previously that for us to override any state in the zn spec we need the key to exist first.

This should solve all the concerns above.

Daanvdplas

Still some comments unresolved and added some.

Daanvdplas

LGTM! Do we need to ensure that the genesis hash is the same as the one already registered on chain?

runtime/mainnet/src/genesis.rs

al3mart · 2025-02-21T11:23:14Z

Do we need to ensure that the genesis hash is the same as the one already registered on chain?

No, it won't be.
We can use all this work for the testnet mirroring mainnet.

runtime/mainnet/src/genesis.rs

* refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * chore(mainnet): remove duplicate module after rebase * refactor(testnet): use genesis presets * chore(testnet): add presetse to runtime api * fix(genesis): bring vec into scope & clean build * docs(genesis): improve testnet genesis spec comments * chore(zombienet): update zombienet network spec * refactor(genesis): inlcude genesis asset * refactor(genesis): amend runtime pattern matcher for testnet * style(chainspec): use Pop for testnet name * refactor(genesis): use Alice as sudo account in local config * refactor(genesis): use sudo as the genesis asset owner * fix(genesis): missing clone for sudo_key * refactor(mainnet): use genesis presets for mainnet runtime. (#473) * refactor(mainnet): use genesis presets * refactor(genesis): removed unused Relay struct * fix(genesis): bring vec into scope & clean build * chore(zombienet): update zombienet network spec * refacotr(genesis): include genesis assets * refactor(genesis): add genesis councilors * test(chainspec): test spec configuration for mainnet * fix(genesis): missing runtime type in sudo tests * test(genesis): add mainnet genesis tests * style(chainspec): use Pop as runtime name * refactor(genesis): don't set ah as owner of genesis asset * fix(chainspec): amend mainnet spec tests * refactor(genesis): apply feedback * refactor(genesis): better endowments * refactor(genesis): remove genesis assets * Update runtime/mainnet/src/genesis.rs * Update runtime/mainnet/src/genesis.rs

* refactor(genesis): wip-use genesis presets for devnet runtime * refactor(devnet): remove spec functions from node * chore(devnet): add presets to runtime api * fix(genesis): bring Vec into scope & clean build * chore(zombienet): update zombienet devenet spec * refactor(genesis): add relay asset at genesis * refactor(genesis): genesis asset is not sufficient * style(chainspec): use Pop * fix(devnet): no endowed accounts on devnet live config * refactor(collator_selection): reduce MaxCandidates to 0 * fix(genesis): bring vec into scope * refactor(genesis): apply feedback * refactor(testnet): use genesis presets for testnet runtime. (#472) * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * chore(mainnet): remove duplicate module after rebase * refactor(testnet): use genesis presets * chore(testnet): add presetse to runtime api * fix(genesis): bring vec into scope & clean build * docs(genesis): improve testnet genesis spec comments * chore(zombienet): update zombienet network spec * refactor(genesis): inlcude genesis asset * refactor(genesis): amend runtime pattern matcher for testnet * style(chainspec): use Pop for testnet name * refactor(genesis): use Alice as sudo account in local config * refactor(genesis): use sudo as the genesis asset owner * fix(genesis): missing clone for sudo_key * refactor(mainnet): use genesis presets for mainnet runtime. (#473) * refactor(mainnet): use genesis presets * refactor(genesis): removed unused Relay struct * fix(genesis): bring vec into scope & clean build * chore(zombienet): update zombienet network spec * refacotr(genesis): include genesis assets * refactor(genesis): add genesis councilors * test(chainspec): test spec configuration for mainnet * fix(genesis): missing runtime type in sudo tests * test(genesis): add mainnet genesis tests * style(chainspec): use Pop as runtime name * refactor(genesis): don't set ah as owner of genesis asset * fix(chainspec): amend mainnet spec tests * refactor(genesis): apply feedback * refactor(genesis): better endowments * refactor(genesis): remove genesis assets * Update runtime/mainnet/src/genesis.rs * Update runtime/mainnet/src/genesis.rs

al3mart mentioned this pull request Feb 17, 2025

refactor(genesis): use runtime genesis presets #471

Merged

4 tasks

al3mart force-pushed the al3mart/refactor-genesis-preset-testnet branch 2 times, most recently from ae4800d to bb2046b Compare February 17, 2025 18:01

al3mart force-pushed the al3mart/refactor-genesis-preset-mainnet branch 2 times, most recently from 10ffbe2 to 7aa5ddf Compare February 17, 2025 18:12

al3mart force-pushed the al3mart/refactor-genesis-preset-testnet branch 2 times, most recently from d87cd19 to 8716241 Compare February 18, 2025 10:44

al3mart force-pushed the al3mart/refactor-genesis-preset-mainnet branch from 7aa5ddf to 0d5c46a Compare February 18, 2025 11:55

al3mart requested a review from a team February 18, 2025 17:34

al3mart added the ready-for-final-review label Feb 18, 2025

al3mart marked this pull request as ready for review February 18, 2025 17:35

al3mart force-pushed the al3mart/refactor-genesis-preset-testnet branch from 62d1013 to 2f47e84 Compare February 18, 2025 19:07

al3mart added 12 commits February 18, 2025 20:10

refactor(mainnet): use genesis presets

e1a7fe5

refactor(genesis): removed unused Relay struct

422604f

fix(genesis): bring vec into scope & clean build

2443fec

chore(zombienet): update zombienet network spec

8bee05f

refacotr(genesis): include genesis assets

99521b9

refactor(genesis): add genesis councilors

7a8d7e6

test(chainspec): test spec configuration for mainnet

b2554f3

fix(genesis): missing runtime type in sudo tests

4b6c672

test(genesis): add mainnet genesis tests

ab49a2f

style(chainspec): use Pop as runtime name

8695c39

refactor(genesis): don't set ah as owner of genesis asset

068aea4

fix(chainspec): amend mainnet spec tests

77cc194

al3mart force-pushed the al3mart/refactor-genesis-preset-mainnet branch from 09c4cfa to 77cc194 Compare February 18, 2025 19:10

Daanvdplas reviewed Feb 19, 2025

View reviewed changes

refactor(genesis): apply feedback

03c47e6

peterwht requested changes Feb 19, 2025

View reviewed changes

refactor(genesis): better endowments

1ea9626

refactor(genesis): remove genesis assets

57f4d96

al3mart requested review from peterwht and Daanvdplas February 20, 2025 08:52

Daanvdplas reviewed Feb 20, 2025

View reviewed changes

Daanvdplas approved these changes Feb 21, 2025

View reviewed changes

runtime/mainnet/src/genesis.rs Outdated Show resolved Hide resolved

runtime/mainnet/src/genesis.rs Outdated Show resolved Hide resolved

al3mart commented Feb 21, 2025

View reviewed changes

runtime/mainnet/src/genesis.rs Outdated Show resolved Hide resolved

Update runtime/mainnet/src/genesis.rs

af72474

al3mart commented Feb 21, 2025

View reviewed changes

runtime/mainnet/src/genesis.rs Outdated Show resolved Hide resolved

Update runtime/mainnet/src/genesis.rs

7d80362

al3mart merged commit f2691e4 into al3mart/refactor-genesis-preset-testnet Feb 21, 2025
3 checks passed

al3mart deleted the al3mart/refactor-genesis-preset-mainnet branch February 21, 2025 11:27

Daanvdplas mentioned this pull request Feb 21, 2025

refactor(testnet): use genesis presets for testnet runtime. #472

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(mainnet): use genesis presets for mainnet runtime. #473

refactor(mainnet): use genesis presets for mainnet runtime. #473

al3mart commented Feb 17, 2025 •

edited

Loading

codecov-commenter commented Feb 18, 2025 •

edited

Loading

Daanvdplas left a comment

peterwht left a comment

peterwht Feb 19, 2025

al3mart Feb 21, 2025

peterwht Feb 19, 2025 •

edited

Loading

al3mart Feb 20, 2025

al3mart Feb 21, 2025

peterwht Feb 19, 2025

Daanvdplas Feb 20, 2025

al3mart Feb 21, 2025

peterwht Feb 19, 2025

al3mart Feb 21, 2025

peterwht Feb 19, 2025

al3mart Feb 21, 2025

al3mart commented Feb 20, 2025 •

edited

Loading

Daanvdplas left a comment

Daanvdplas left a comment

al3mart commented Feb 21, 2025

	// The initial balances at genesis.
	// The initial balances at genesis for local testing only.

refactor(mainnet): use genesis presets for mainnet runtime. #473

refactor(mainnet): use genesis presets for mainnet runtime. #473

Conversation

al3mart commented Feb 17, 2025 • edited Loading

Requirements:

codecov-commenter commented Feb 18, 2025 • edited Loading

Codecov Report

Daanvdplas left a comment

Choose a reason for hiding this comment

peterwht left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterwht Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

al3mart commented Feb 20, 2025 • edited Loading

Daanvdplas left a comment

Choose a reason for hiding this comment

Daanvdplas left a comment

Choose a reason for hiding this comment

al3mart commented Feb 21, 2025

al3mart commented Feb 17, 2025 •

edited

Loading

codecov-commenter commented Feb 18, 2025 •

edited

Loading

peterwht Feb 19, 2025 •

edited

Loading

al3mart commented Feb 20, 2025 •

edited

Loading