Skip to content

Commit

Permalink
refactor: ci and sp_mmr
Browse files Browse the repository at this point in the history
  • Loading branch information
Daanvdplas committed Dec 18, 2024
1 parent 57bdbcd commit 855146b
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 31 deletions.
54 changes: 27 additions & 27 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ jobs:
run: |
cargo check --release --locked --features=runtime-benchmarks,try-runtime
check-ismp:
needs: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: "./.github/actions/init"
- name: Check Build with ISMP
run: |
cargo check --release --locked --features=ismp,runtime-benchmarks,try-runtime
# check-ismp:
# needs: lint
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: "./.github/actions/init"
# - name: Check Build with ISMP
# run: |
# cargo check --release --locked --features=ismp,runtime-benchmarks,try-runtime

clippy:
needs: lint
Expand All @@ -73,24 +73,24 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
args: --release --locked --features=runtime-benchmarks

clippy-ismp:
needs: lint
runs-on: ubuntu-latest
permissions:
checks: write
env:
RUSTFLAGS: "-Wmissing_docs"
SKIP_WASM_BUILD: 1
steps:
- uses: actions/checkout@v4

- uses: "./.github/actions/init"

- name: Annotate with Clippy warnings
uses: actions-rs/clippy-check@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
args: --release --locked --features=runtime-benchmarks,ismp
# clippy-ismp:
# needs: lint
# runs-on: ubuntu-latest
# permissions:
# checks: write
# env:
# RUSTFLAGS: "-Wmissing_docs"
# SKIP_WASM_BUILD: 1
# steps:
# - uses: actions/checkout@v4
#
# - uses: "./.github/actions/init"
#
# - name: Annotate with Clippy warnings
# uses: actions-rs/clippy-check@v1
# with:
# token: ${{ secrets.GITHUB_TOKEN }}
# args: --release --locked --features=runtime-benchmarks,ismp

test:
needs: lint
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ jobs:
# if devnet, build the node with ismp feature
if [ "$RUNTIME" == "devnet" ]; then
echo "NODE_BUILD_OPTS=--features on-chain-release-build,ismp" >> $GITHUB_ENV
# echo "NODE_BUILD_OPTS=--features on-chain-release-build,ismp" >> $GITHUB_ENV
echo "NODE_BUILD_OPTS=--features on-chain-release-build" >> $GITHUB_ENV
else
echo "NODE_BUILD_OPTS=--features on-chain-release-build" >> $GITHUB_ENV
fi
Expand Down
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ sp-genesis-builder = { version = "0.14.0", default-features = false }
sp-inherents = { version = "33.0.0", default-features = false }
sp-io = { version = "37.0.0", default-features = false }
sp-keystore = "0.40.0"
sp-mmr-primitives = { version = "33.0.0", default-features = false }
sp-offchain = { version = "33.0.0", default-features = false }
sp-runtime = { version = "38.0.0", default-features = false }
sp-session = { version = "34.0.0", default-features = false }
Expand Down Expand Up @@ -191,6 +190,8 @@ paseo-runtime-constants = { git = "https://github.com/polkadot-fellows/runtimes"
# paseo-runtime = { git = "https://github.com/paseo-network/runtimes/", tag = "v1.2.5-system-chains", default-features = false }
# paseo-runtime-constants = { git = "https://github.com/paseo-network/runtimes/", tag = "v1.2.5-system-chains", default-features = false }

# ISMP
#sp-mmr-primitives = { version = "33.0.0", default-features = false }
#ismp = { git = "https://github.com/r0gue-io/ismp", branch = "polkadot-v1.14.0", default-features = false }
#ismp-parachain = { git = "https://github.com/r0gue-io/ismp", branch = "polkadot-v1.14.0", default-features = false }
#ismp-parachain-inherent = { git = "https://github.com/r0gue-io/ismp", branch = "polkadot-v1.14.0", default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion runtime/devnet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ sp-core.workspace = true
sp-genesis-builder.workspace = true
sp-inherents.workspace = true
sp-io.workspace = true
sp-mmr-primitives.workspace = true
sp-offchain.workspace = true
sp-runtime.workspace = true
sp-session.workspace = true
Expand Down Expand Up @@ -93,6 +92,7 @@ parachain-info.workspace = true
parachains-common.workspace = true

## ISMP
#sp-mmr-primitives.workspace = true
#ismp.workspace = true
#ismp-parachain.workspace = true
#ismp-parachain-runtime-api.workspace = true
Expand Down

0 comments on commit 855146b

Please sign in to comment.