Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: polkadot v1.12.0 #26

Merged
merged 7 commits into from
Jun 21, 2024
Merged

chore: polkadot v1.12.0 #26

merged 7 commits into from
Jun 21, 2024

Conversation

Daanvdplas
Copy link
Collaborator

No description provided.

@Daanvdplas Daanvdplas requested a review from al3mart June 12, 2024 16:50
@Daanvdplas Daanvdplas force-pushed the daan/chore-polkadot-v1.12.0 branch from fb93ec8 to 836444a Compare June 12, 2024 16:51
Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

I think it could be useful to include paritytech/polkadot-sdk#3872 but we can tackle in a different pr 👌

@AlexD10S AlexD10S self-requested a review June 14, 2024 16:19
@evilrobot-01
Copy link
Contributor

Please can the merge conflicts be resolved after v1.11 merged.

@Daanvdplas
Copy link
Collaborator Author

Please can the merge conflicts be resolved after v1.11 merged.

@al3mart will do this today

@al3mart
Copy link
Contributor

al3mart commented Jun 17, 2024

This should be ready for final review / merge. But let's get #29 merged first.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But let's wait to merge until assets-parachain and contracts-parachain are at v1.11.0

@Daanvdplas Daanvdplas merged commit 85d9781 into main Jun 21, 2024
6 checks passed
@Daanvdplas Daanvdplas deleted the daan/chore-polkadot-v1.12.0 branch June 21, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants