Add code to test test_that calls. #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (result$passed) return() | ||
| new_failure <- list() | ||
| new_failure[[test]] = result | ||
| failures <<- c(failures, new_failure) |
There was a problem hiding this comment.
I think those three lines are equivalent to failures[[test]] <<- new_failure
There was a problem hiding this comment.
touche. (originally there was a browser() call before the last line while debugging ...)
|
Looking good. Can you rebase (once I've merged the other pull request) and squash? (And add a similar bullet to NEWS) |
Currently, `dir_state` can fail in unfortuate ways when a file disappears between reading a directory listing and calculating a hash of its contents; this patch fixes the problem by catching the failure and returning NA.
This change adds a new reporter that simply gathers expectation failures silently, and rewrites `inst/tests/test-xxx.r` to use it.
|
This is ready to go modulo merging the other pull request -- it's based on that one, so presumably it "just works" once the first is merged. There was a little excitement on my side when I accidentally used |
hadley
added a commit
that referenced
this pull request
Jul 19, 2013
Add code to test test_that calls.
|
Thanks again for all this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make
test-xxx.ractually testable, which was complicated by the fact thattest_thatis designed not to return anything. The natural fit seemed to be to pass in a reporter that did my bidding, which is what I've done. I think the result is thattest_test_thatworks fairly reasonably, but if you think it's gotten too fancy for its own good, that's okay, too.(Note that this branch is based on the other testing branch, so the code will look repetitive -- only the last diff is new. Is there a way to tell github to only show the relative changes? I'll clean this up once the other pull request is in.)