New option testthat.summary.omit_dots to omit progress dots #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing in RStudio seems to ignore .Rprofile, I don't know how to set this option globally so that it is also respected when testing in RStudio. |
hadley
reviewed
Dec 15, 2016
| @@ -41,22 +43,23 @@ SummaryReporter <- R6::R6Class("SummaryReporter", inherit = Reporter, | |||
| }, | |||
|
|
|||
| add_result = function(context, test, result) { | |||
| dot <- NULL | |||
There was a problem hiding this comment.
I don't particularly like the flow of logic here, but I can't see an obviously better approach.
| @@ -65,7 +65,7 @@ test_that("reporters produce consistent output", { | |||
| save_report("debug") | |||
| ) | |||
| save_report("check", error_regexp = NULL) | |||
| save_report("summary", SummaryReporter$new(show_praise = FALSE)) | |||
| save_report("summary", SummaryReporter$new(show_praise = FALSE, omit_dots = FALSE)) | |||
There was a problem hiding this comment.
I think we also need a test with omit_dots = TRUE
There was a problem hiding this comment.
Added as "summary-no-dots".
|
And a bullet for news please (I'll handle any merge conflicts) |
krlmlr
force-pushed
the
f-dot-performance
branch
from
9da95a7 to
60fadff
Compare
hadley
reviewed
Dec 19, 2016
| option `testthat.summary.max_reports` (default 15) is reached | ||
| (#520). | ||
|
|
||
| * New option `testthat.summary.omit_dots`, default to `FALSE`. Setting to `TRUE` hides the progress dots from the output of the summary reporter, which speeds up tests by a small margin (#502). |
krlmlr
force-pushed
the
f-dot-performance
branch
from
a4f3311 to
fca838b
Compare
|
Added help description, should be complete now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dots account for roughly 10%-20% of the testing time, this is difficult to parallelize (#486). Default: Show dots.
Now also fixes #520.