New expect_output_file() #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 9, 2016 15:17
now updating golden files in case of failure
krlmlr
force-pushed
the
feature/expect-output-file
branch
from
47272e3 to
bcb9fd3
Compare
|
I've been using this in some projects already, works for me (and for testthat). Any chance to include it in the upcoming point release, perhaps marked as "experimental"? |
|
I think so - can you add a bullet to NEWS and I'll merge |
added 2 commits
April 18, 2016 22:33
|
Done, Travis test ok. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compares output against file contents, and optionally updates it.
With test, and using it already in this package.
I'm not really happy with the name, any suggestions?