Fix failure_msg and success_msg for throws_error #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Could you please also add a bullet to NEWS. |
|
Done: 2367d60 |
|
Can you cite your github username and this issue too please? |
|
Rectified: nealrichardson@4650f50 |
hadley
added a commit
that referenced
this pull request
Jan 12, 2016
Fix failure_msg and success_msg for throws_error
|
Thanks! Fwiw you can just say "PTAL" when you need me to take another look. |
krlmlr
pushed a commit
to krlmlr/testthat
that referenced
this pull request
Jan 13, 2016
Overriding changes of r-lib#342, because they were already implemented here (albeit differently).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
expect_errorwas oddly printing that the "code raised an error" when the expectation correctly failed on code that did not error. Turns out thefailure_msgandsuccess_msgarguments were in the wrong order inthrows_error. Test and fix.