Snapshot hint override #1608
Snapshot hint override #1608
Conversation
|
I think the test needs to depend on the new cli version, to fix the CI failures, which run with old cli. |
|
Oops, I forgot to check that it had actually been accepted by CRAN. |
|
Unrelated to this PR, but seems like the variants are not working properly here: https://github.com/r-lib/testthat/runs/6147007072?check_suite_focus=true#step:7:180 Maybe when our CI |
| @@ -1,5 +1,7 @@ | |||
| # testthat (development version) | |||
|
|
|||
| * Fix bug revealed by fix to another bug in cli (#1606). | |||
|
|
|||
There was a problem hiding this comment.
I am not sure if this is very useful to the end user, maybe we don't need to mention it at all, as nobody has really seen this bug?
There was a problem hiding this comment.
Yeah, not sure why I wrote that. I'll just add something generic about cli.
| * Run `snapshot_accept('bar.R')` to accept the change | ||
| * Run `snapshot_review('bar.R')` to interactively review the change | ||
| * Run `]8;;rstudio:run:testthat::snapshot_accept('bar.R')snapshot_accept('bar.R')]8;;` to accept the change | ||
| * Run `]8;;rstudio:run:testthat::snapshot_review('bar.R')snapshot_review('bar.R')]8;;` to interactively review the change |
There was a problem hiding this comment.
cli is not using the ideal ansi sequence for links currently, because rstudio does not support that yet. But once we fix this in rstudio, cli will switch to that as well, so these snapshots will change. fyi.
Fixes #1606