Escape reserved characters teamcity reporter messages #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teamcity fails to report tests which contain an unescaped reserved character in the message text. Now the teamcity reporter escapes each of these characters
| @@ -55,3 +61,7 @@ TeamcityReporter <- setRefClass("TeamcityReporter", contains = "Reporter", | |||
| } | |||
| ) | |||
| ) | |||
|
|
|||
| escapedString <- function(s) { | |||
| gsub("(['|]|\\[|\\])", "|\\1", s) | |||
There was a problem hiding this comment.
Could you please name this teamcity_escape?
|
function name changed to teamcity_escape as requested |
|
And can you please add a bullet to NEWS? |
|
added to NEWS |
|
Thanks - had to merge by hand. |
|
Since you're familiar with teamcity - is there a standard way to report skipped tests? |
|
The message ##teamcity[testIgnored name='testName' message='ignore comment'] Will inform teamcity that the test ‘testName’ existed but was ignored. This replaces the usual test started/ended messages |
|
Thanks - I just did a fairly major refactoring of the teamcity reporter. Would you mind taking a look? It looks ok to me on casual inspection of the the output. |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teamcity fails to report tests which contain an unescaped reserved character in the message text.
This means that TeamCity does not report all tests, and can miss failed tests.
Now the TeamCity reporter escapes each of these characters in its messages to TeamCity.