Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partial match #1184

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix partial match #1184

merged 1 commit into from
Oct 2, 2020

Conversation

jimhester
Copy link
Member

No description provided.

@jimhester
Copy link
Member Author

options(warnPartialMatchDollar = TRUE) makes it pretty easy to catch these, though they rarely cause problems in practice of course.

@gaborcsardi
Copy link
Member

Thanks!

@brodieG
Copy link
Contributor

brodieG commented Sep 30, 2020 •
edited
Loading

Note also fixed in #1183, so we'll have to reconcile on merge.

EDIT: I'll remove my fix.

@brodieG brodieG mentioned this pull request Sep 30, 2020
Merged
brodieG added a commit to brodieG/testthat that referenced this pull request Sep 30, 2020
@brodieG
remove partial match fix
bbc7d3c 
In order to avoid conflict with r-lib#1184
@hadley hadley merged commit f1dd05c into r-lib:master Oct 2, 2020
@hadley
Copy link
Member

hadley commented Oct 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi Awaiting requested review from gaborcsardi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimhester @gaborcsardi @brodieG @hadley