Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing the version argument of saveRDS in expect_known_value() #888

Closed
lorenzwalthert opened this issue Jun 19, 2019 · 1 comment · Fixed by #900
Closed

Exposing the version argument of saveRDS in expect_known_value() #888

lorenzwalthert opened this issue Jun 19, 2019 · 1 comment · Fixed by #900

Comments

@lorenzwalthert
Copy link

This could be helpful because R < 3.6 can't read version 3, and for that reason, newly created reference objects (or updated ones) in a developer environment with R >= 3.6 have to be manually read and written back in version 2 for tests to pass on R < 3.6.
@lorenzwalthert lorenzwalthert changed the title Exposing the version argument of saveRDS in expect_known_value() and friends Exposing the version argument of saveRDS in expect_known_value() Jun 19, 2019
@jennybc
Copy link
Member

jennybc commented Jul 15, 2019 •
edited
Loading

Also affects expect_equal_to_reference()

I now realize that expect_equal_to_reference() is basically soft-deprecated in favour of expect_known_value().

jennybc added a commit that referenced this issue Jul 15, 2019
@jennybc
Make serialization version 2 the default
c926c18 
Closes #888
@jennybc jennybc mentioned this issue Jul 15, 2019
Merged
hadley pushed a commit that referenced this issue Jul 15, 2019
@jennybc @hadley
Make serialization version 2 the default (#900)
af11603 
Fixes #888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make serialization version 2 the default r-lib/testthat
2 participants
@jennybc @lorenzwalthert