Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more information when expect_condition() and friends fail #1987

Closed
hadley opened this issue Sep 6, 2024 · 0 comments · Fixed by #2003
Closed

Provide more information when expect_condition() and friends fail #1987

hadley opened this issue Sep 6, 2024 · 0 comments · Fixed by #2003
Labels
conditions feature a feature request or enhancement
Milestone
v3.2.2

Comments

@hadley
Copy link
Member

hadley commented Sep 6, 2024 

resp2 <- req %>% req_perform(path = path2)` did not throw the expected condition

Would be better as

resp2 <- req %>% req_perform(path = path2)` did not throw the expected `httr2_cache_save` condition. 
Conditions observed: httr2_cache_cached
@hadley hadley added feature a feature request or enhancement conditions labels Oct 22, 2024
@hadley hadley added this to the v3.2.2 milestone Oct 22, 2024
hadley added a commit that referenced this issue Oct 29, 2024
@hadley
Display expected condition class
d550bfa 
In `expect_condition()` and friends, when `class` is supplied and the expectation fails.

Fixes #1987
@hadley hadley mentioned this issue Oct 29, 2024
Merged
hadley added a commit that referenced this issue Oct 29, 2024
@hadley
Display expected condition class (#2003)
6166099 
In `expect_condition()` and friends, when `class` is supplied and the expectation fails.

Fixes #1987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conditions feature a feature request or enhancement
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging a pull request may close this issue.

Display expected condition class r-lib/testthat
1 participant
@hadley