Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left alignment in function calls #774

Merged
merged 8 commits into from
Apr 14, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Apr 13, 2021

Contributes towards #258.
Here is how the current PR would change benchmark results when merged into master:

  • cache_applying: 0.03 -> 0.03 (0.8%)
  • cache_recording: 0.92 -> 0.92 (-0.1%)
  • without_cache: 2.74 -> 2.61 (-4.9%)

63c3749

  • cache_applying: 0.03 -> 0.03 (17.4%)
  • cache_recording: 1.03 -> 0.99 (-4.4%)
  • without_cache: 3.05 -> 2.89 (-5.3%)

e00de3e

  • cache_applying: 0.03 -> 0.03 (14.8%)
  • cache_recording: 1.18 -> 1.12 (-5%)
  • without_cache: 3.31 -> 3.28 (-1%)

@codecov-io
Copy link

Codecov Report

Merging #774 (d63c129) into master (c69d5fd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
- Coverage   90.55%   90.54%   -0.02%     
==========================================
  Files          47       47              
  Lines        2393     2390       -3     
==========================================
- Hits         2167     2164       -3     
  Misses        226      226              
Impacted Files Coverage Δ
R/detect-alignment-utils.R 90.47% <100.00%> (ø)
R/detect-alignment.R 97.56% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69d5fd...d63c129. Read the comment docs.

@lorenzwalthert lorenzwalthert force-pushed the no-posid-for-alignment branch from ad7b02e to 63c3749 Compare April 13, 2021 19:58
@lorenzwalthert lorenzwalthert changed the title Speed things up by not calculating pos id Left alignment in function calls Apr 13, 2021
@lorenzwalthert lorenzwalthert merged commit d3e11e3 into r-lib:master Apr 14, 2021
@lorenzwalthert lorenzwalthert deleted the no-posid-for-alignment branch April 14, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants