Support setMethodS3() and setConstructorS3() of R.methodsS3 and R.oo #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Oct 10, 2016
| class <- as.character(call[[3]]) | ||
| name <- paste(method, class, sep=".") | ||
| value <- get(name, env) | ||
| value <- standardise_obj(name, value, env, block) |
There was a problem hiding this comment.
Maybe just move get(...) into the standarise_obj() call?
hadley
reviewed
Oct 10, 2016
| value <- get(name, env) | ||
| value <- standardise_obj(name, value, env, block) | ||
| object(value, name) | ||
|
|
|
Just a couple of tiny things; otherwise looks good. Can you please also add a bullet to NEWS? |
|
Done. Though, not sure if I PR's should be referenced in NEWS or just issues. |
hadley
reviewed
Oct 10, 2016
| @@ -1,5 +1,8 @@ | |||
| # roxygen2 5.0.1.9000 | |||
|
|
|||
| * S3 method declarations via setMethodS3() of R.methodS3 and function | |||
| declarations via setConstructorS3() of R.oo are now supported (#525). | |||
There was a problem hiding this comment.
Can you include your github user name there too?
I don't have a firm policy on issues vs. PRs — but I usually cite the issue number if there is one, other the PR is fine.
|
Added user name. |
|
Thanks! |
Lucaweihs
added a commit
to Lucaweihs/roxygen
that referenced
this pull request
Jul 14, 2017
…:setConstructorS3. This bug was introduced in code review of pull request r-lib#525 (the arguments to a call to standardise_obj were incorrectly changed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R.methodsS3::setMethodS3(name, class, definition)defines S3 methodname.class <- definitionandR.oo::setConstructorS3(name, definition)defines R functionname <- definition. With this patch, roxygen2 recognizes the above constructors accordingly.For the records, the background for this PR is private email 'R.methodsS3 with roxygen2' on 2016-10-03 from @martynplummer to me and @hadley (cc: @Lucaweihs and Mathias Drton). The patch has been validated by me and independently by @martynplummer.