Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check for unexported S3 methods #1594

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Improve check for unexported S3 methods #1594

merged 3 commits into from
Jul 10, 2024

Conversation

jranke
Copy link
Contributor

@jranke jranke commented Feb 9, 2024

Fixes #1593

@alexpghayes alexpghayes mentioned this pull request Mar 28, 2024
Closed
@olivroy olivroy mentioned this pull request May 19, 2024
Closed
@hadley
Copy link
Member

hadley commented Jul 9, 2024

Thank you! Do you want to add a news bullet? It should briefly describe the change and end with (@yourname, #issuenumber).

@jranke
Copy link
Contributor Author

jranke commented Jul 9, 2024

Good point, I added a NEWS entry as suggested.

@hadley hadley merged commit 7c12664 into r-lib:main Jul 10, 2024
13 checks passed
@hadley
Copy link
Member

hadley commented Jul 10, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking for missing S3 method exports hangs "forever" if you have large data objects in the package
2 participants
@jranke @hadley