-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
And update docs about new evaluation strategy in light of failure.
- Loading branch information
Showing
8 changed files
with
97 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,20 @@ | ||
## Comments | ||
|
||
### May 14, 2019 | ||
|
||
Submitting small enhancements. Please let me know if there is anything I can do. | ||
|
||
Thank you for your time, | ||
- Winston | ||
|
||
|
||
## Test environments | ||
* local OS X install, R 3.6.0 | ||
* travis-ci ubuntu 14.04 | ||
* R 3.5.3 | ||
* R 3.6.0 | ||
* R Under development (unstable) (2019-05-13 r76492) | ||
* win-builder (devel and release) | ||
* R version 3.5.3 (2019-03-11) | ||
* R version 3.6.0 (2019-04-26) | ||
* R Under development (unstable) (2019-05-12 r76489) | ||
* rhub | ||
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit | ||
* Ubuntu Linux 16.04 LTS, R-release, GCC | ||
* Fedora Linux, R-devel, clang, gfortran | ||
* Debian Linux, R-devel, GCC ASAN/UBSAN | ||
|
||
## R CMD check results | ||
|
||
0 errors | 0 warnings | 0 notes | ||
|
||
|
||
## revdepcheck results | ||
|
||
We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. | ||
We checked 8 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. | ||
|
||
* We saw 0 new problems | ||
* We saw 1 new problems | ||
* We failed to check 0 packages | ||
|
||
Issues with CRAN packages are summarised below. | ||
|
||
### New problems | ||
(This reports the first line of each new failure) | ||
|
||
* tidyft | ||
Patch submitted at https://github.com/hope-data-science/tidyft/pull/4 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,4 @@ checks.noindex | |
library.noindex | ||
data.sqlite | ||
*.html | ||
cloud.noindex |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,8 @@ | ||
# Platform | ||
|
||
|field |value | | ||
|:--------|:----------------------------| | ||
|version |R version 3.6.0 (2019-04-26) | | ||
|os |macOS Mojave 10.14.4 | | ||
|system |x86_64, darwin15.6.0 | | ||
|ui |X11 | | ||
|language |(EN) | | ||
|collate |en_US.UTF-8 | | ||
|ctype |en_US.UTF-8 | | ||
|tz |America/New_York | | ||
|date |2019-05-14 | | ||
|
||
# Dependencies | ||
|
||
|package |old |new |Δ | | ||
|:-------|:-----|:-----|:--| | ||
|profvis |0.3.5 |0.3.6 |* | | ||
|
||
# Revdeps | ||
|
||
## All (3) | ||
## New problems (1) | ||
|
||
|package |version |error |warning |note | | ||
|:------------|:-------|:-----|:-------|:----| | ||
|gtable |0.3.0 | | | | | ||
|RobinHood |1.0.5 | | | | | ||
|SpaDES.tools |0.3.2 | | | | | ||
|package |version |error |warning |note | | ||
|:-------|:-------|:------|:-------|:--------| | ||
|[tidyft](problems.md#tidyft)|0.5.7 |__+1__ | |1 __+1__ | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
## revdepcheck results | ||
|
||
We checked 8 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. | ||
|
||
* We saw 1 new problems | ||
* We failed to check 0 packages | ||
|
||
Issues with CRAN packages are summarised below. | ||
|
||
### New problems | ||
(This reports the first line of each new failure) | ||
|
||
* tidyft | ||
checking running R code from vignettes ... ERROR | ||
checking re-building of vignette outputs ... NOTE | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,60 @@ | ||
*Wow, no problems at all. :)* | ||
# tidyft | ||
|
||
<details> | ||
|
||
* Version: 0.5.7 | ||
* GitHub: https://github.com/hope-data-science/tidyft | ||
* Source code: https://github.com/cran/tidyft | ||
* Date/Publication: 2023-01-08 14:40:01 UTC | ||
* Number of recursive dependencies: 47 | ||
|
||
Run `revdepcheck::cloud_details(, "tidyft")` for more info | ||
|
||
</details> | ||
|
||
## Newly broken | ||
|
||
* checking running R code from vignettes ... ERROR | ||
``` | ||
Errors in running code in vignettes: | ||
when running code in ‘Introduction.Rmd’ | ||
... | ||
> profvis({ | ||
+ res1 = ft %>% select_fst(Species, Sepal.Length, Sepal.Width, | ||
+ Petal.Length) %>% dplyr::select(-Petal.Length) %>% dplyr::re .... [TRUNCATED] | ||
> setequal(res1, res2) | ||
When sourcing ‘Introduction.R’: | ||
Error: object 'res1' not found | ||
Execution halted | ||
‘Introduction.Rmd’ using ‘UTF-8’... failed | ||
``` | ||
* checking re-building of vignette outputs ... NOTE | ||
``` | ||
Error(s) in re-building vignettes: | ||
... | ||
--- re-building ‘Introduction.Rmd’ using rmarkdown | ||
Quitting from lines 113-183 [unnamed-chunk-5] (Introduction.Rmd) | ||
Error: processing vignette 'Introduction.Rmd' failed with diagnostics: | ||
object 'res1' not found | ||
--- failed re-building ‘Introduction.Rmd’ | ||
SUMMARY: processing the following file failed: | ||
‘Introduction.Rmd’ | ||
Error: Vignette re-building failed. | ||
Execution halted | ||
``` | ||
## In both | ||
* checking Rd cross-references ... NOTE | ||
``` | ||
Packages unavailable to check Rd xrefs: ‘tidyfst’, ‘tidyr’, ‘fastDummies’ | ||
``` | ||