Sending "multi_ack" in git-v1 #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Advertising "multi_ack" support for the client in Git protocol V1 code.
|
Thanks! It does not break the Bioconductor git repo, so it is probably fine everywhere. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 25, 2024
# pak 0.7.1 * pak can now handle the case when `Config/Needs/*` dependencies are requested for package from a repository. * pak uses safer `*printf()` format strings now. # pak 0.7.0 * pak now correctly handles the latest GitHub release with the `@*release` notation (@pawelru, r-lib/pkgdepends#321) * pak now correctly handles having multiple instances of the same package in the metadata, with different R version requirements (#534, #538, r-lib/pkgdepends#331). * `git::` package references work better now for Azure DevOps (@jameslairdsmith, r-lib/pkgdepends#333, r-lib/pkgdepends#342). * pak now does a better job at accepting installed packages, and avoids reinstalling more packages than needed when using a lock file (r-lib/actions#759, r-lib/pkgdepends#338). # pak 0.6.0 * pak now requires R >= 3.5.0. * Many improvements in system requirements support: - New functions: - `pkg_sysreqs()`: calculate system requirements of packages. - `sysreqs_db_list()`, `sysreqs_db_match()`, `sysreqs_db_update()`: query the system requirements database. - `sysreqs_list_system_packages()`, `sysreqs_check_installed()`, `sysreqs_fix_installed()`: query and install missing system packages. - `sysreqs_platforms()`: list supported platforms. - The installation proposal, printed before installation, now includes required and missing system packages, on supported platforms. - New `sysreqs_platform` configuration option to override the auto-detected platform. - Faster, asynchronous system requirements lookup. - pak now does not reinstall system requirements by default, if they are already installed. (You can force a reinstall/upgrade with the `sysreqs_update` configuration option.) * New `gitlab::` package source to install packages from GitLab (r-lib/pkgdepends#315). * pak now correctly parses multiple `git::` packages at once (r-lib/pkgdepends#318). * `git::` package sources now support version 1 of the git protocol. E.g. the Bioconductor git repositories now work: `git::https://git.bioconductor.org/packages/limma` (r-lib/pkgdepends#314). * The `platforms` config parameter now works correctly with `deps::` package sources (#522). * New `include_linkingto` config parameter to always include `LinkingTo` packages in the solution, even for binaries (https://github.com/r-lib/pkgdepends/issues/485). * `pkg_name_check()` now does not include Acromine results, because the web site was unstable. * In `repo_add()` and `repo_resolve()` the `MRAN@` prefix is now deprecated and resolves to PPM, because MRAN will be retired soon. See more at <https://posit.co/blog/migrating-from-mran-to-posit-package-manager/>. * The metadata cache now has `SystemRequirements` information for Bioconductor packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been spending a little while trying to get pak to work with the Bank of England's locally hosted version of Azure DevOps, but I've been getting an HTTP error when pak (or more accurately pkgdepends) tries to get the target package's DESCRIPTION file. The various error messages point towards pak not advertising it's "multi_ack" support in git protocol V1.
I've tested the fix in this PR internally for the Bank's R packages and it works for us. I unfortunately can't provide a reprex, but there might be a public instance of Azure DevOps that I don't know about which could help with that.