Allow turning symbols off on UTF-8 platforms

[krlmlr]

Related: #27.

I'm not sure this is the best way to do this, but the original code didn't support turning it off at all (short of setting LC_CTYPE = "C").

[gaborcsardi]

I might be missing sg, but this will not fix the problem, imo. I think the correct solution is

getOption("cli.unicode", l10n_info()$`UTF-8`)

no?

[codecov-io]

Codecov Report

Merging #29 into master will increase coverage by 0.79%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master     #29     +/-   ##
========================================
+ Coverage      60%   60.8%   +0.8%     
========================================
  Files           9       9             
  Lines         375     375             
========================================
+ Hits          225     228      +3     
+ Misses        150     147      -3

Impacted Files	Coverage Δ
R/utils.R	51.72% <100%> (ø)	⬆️
R/box-styles.R	100% <0%> (+4.61%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07cd5f...965277b. Read the comment docs.

[gaborcsardi]

I don't think we have map_chr

[krlmlr]

Okay to add purrr-compat.R?

[gaborcsardi]

Don't worry about the test failure. I am fixing those. It is a mess because if testthat now (almost!) parsing everything in UTF-8 and a parse() bug.

[gaborcsardi]

Can you please just undo the test fix or remove the map_chr and use something like paste(rep(char, x), collapse = "") instead?

[krlmlr]

The test fix seems a consequence of my changes, can't undo without test failures. ?

[gaborcsardi]

That's fine, don't worry about test failures. I'll fix the tests, once testthat is fixed (r-lib/testthat#605)

[krlmlr]

Done.

[krlmlr]

(Although I'm fairly certain we still need to adapt the test like I did in 0ce2b5a.)

[gaborcsardi]

Thanks! A rule test case is easy adapt like that, but more complicated output is hard. rebox() will take care of this, once testthat is correct. It actually does work fine with stable testthat, but dev testthat changed how it reads and parses files.