Skip to content

Commit

Permalink
Minor cleanup for PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
quux00 committed Jan 16, 2025
1 parent be26238 commit d5aea8c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@ public void analyzedPlan(
var listener = SubscribableListener.<EnrichResolution>newForked(
l -> enrichPolicyResolver.resolvePolicies(targetClusters, unresolvedPolicies, l)
).<PreAnalysisResult>andThen((l, enrichResolution) -> resolveFieldNames(parsed, enrichResolution, l));

// first resolve the lookup indices, then the main indices
for (TableInfo lookupIndex : preAnalysis.lookupIndices) {
listener = listener.andThen((l, preAnalysisResult) -> { preAnalyzeLookupIndex(lookupIndex, preAnalysisResult, l); });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ static void updateExecutionInfoWithClustersWithNoMatchingIndices(EsqlExecutionIn

/**
* Rules enforced at planning time around non-matching indices
* 1. fail query if no matching indices on any cluster (VerificationException) - that is handled elsewhere (TODO: document where)
* 2. fail query if a cluster has no matching indices *and* a concrete index was specified
* 1. fail query if no matching indices on any cluster (VerificationException) - that is handled elsewhere
* 2. fail query if a cluster has no matching indices *and* a concrete index was specified - handled here
*/
String fatalErrorMessage = null;
/*
Expand Down

0 comments on commit d5aea8c

Please sign in to comment.