Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully transition to pyproject #131

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fully transition to pyproject #131

merged 2 commits into from
Aug 29, 2024

Conversation

kba
Copy link
Contributor

@kba kba commented Aug 27, 2024

No description provided.

mikegerber
mikegerber approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@mikegerber mikegerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Personally, I would just delete setup.py (but we have a discussion about that in Gitter)
  • Use of setuptools-ocrd looks good now.

I haven't actually tested if it builds, but LGTM

cneud
cneud approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@cneud cneud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thx!

@cneud cneud requested a review from vahidrezanezhad August 27, 2024 17:20
@kba kba mentioned this pull request Aug 29, 2024
Merged
@kba kba marked this pull request as ready for review August 29, 2024 15:18
@kba
Copy link
Contributor Author

kba commented Aug 29, 2024

I've removed the setup.py, like @mikegerber suggested and as discussed today. There is really no benefit of being backwards-compatible with outdated build methods.

@cneud
Copy link
Member

cneud commented Aug 29, 2024

I've removed the setup.py, like @mikegerber suggested

Agreed! Any idea why the test is failing now though?

@kba
Copy link
Contributor Author

kba commented Aug 29, 2024

Any idea why the test is failing now though?

Intermittent issue with the cache in GHA. Restarted, tests pass.

@cneud cneud merged commit 9367f86 into main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cneud cneud cneud approved these changes

@mikegerber mikegerber mikegerber approved these changes

@vahidrezanezhad vahidrezanezhad Awaiting requested review from vahidrezanezhad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kba @cneud @mikegerber @vahidrezanezhad