Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Setonix #817

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Fixes for Setonix #817

merged 5 commits into from
Dec 12, 2024

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Dec 11, 2024

Description

Uses amrex:: math functions instead of std:: math functions in some cases. This is due to problems with the GCC 14 C++ standard library headers.

Adds new setonix.profile and job scripts. 64-node jobs appear to work now.

Scaling test:
Screenshot 2024-12-11 at 2 25 37 PM

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Setonix labels Dec 11, 2024
@BenWibking
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@BenWibking
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2024
@BenWibking BenWibking added this pull request to the merge queue Dec 12, 2024
Merged via the queue into development with commit 993f0bc Dec 12, 2024
23 checks passed
@BenWibking BenWibking deleted the BenWibking/fix-for-setonix branch December 12, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer Setonix size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants