Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm version in dependencies_hip.sh #816

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Dec 11, 2024

Description

For GitHub actions CI tests, compile the code using ROCm 5.7.1 (the latest version available on Setonix).

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@BenWibking BenWibking marked this pull request as ready for review December 11, 2024 18:45
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2024
@BenWibking BenWibking added this pull request to the merge queue Dec 11, 2024
Merged via the queue into development with commit e45f4e7 Dec 11, 2024
21 checks passed
@BenWibking BenWibking deleted the BenWibking/update-rocm-version branch December 12, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants