Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RSLA in all dust tests #811

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Conversation

chongchonghe
Copy link
Contributor

@chongchonghe chongchonghe commented Dec 10, 2024

Description

Since in all practical runs we will use RSLA, it's important to test that our RSLA method gives the exacted result. In this PR, I update RadDust, RadMarshakDust, and RadMarshakDustPE tests to use RSLA. The analytical solutions are updated to include RSLA as well. In all these tests, RSLA changes the results significantly because 1) in the Marshak tests, the problem is in the optically thin limit, so the propagation speed is reduced, or 2) in the RadDust test, the gas has an initial temperature of $T_0$ and cools to a temperature $T_1$ through thermal emission: $T_0$ $C_V T_0 = C_V T_1 + (\hat{c} / c) a_R T_1^4$ .

This also prepares for the variable RSLA method I'm working on.

Related issues

None.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 10, 2024
@chongchonghe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but I don't think values of $\hat c / c$ of 0.5 or 0.8 are realistic. I don't think we'd ever run with a value greater than $0.1$. Otherwise, we might as well just use the full speed of light, or give up and use a fully implicit method.

src/problems/RadDustMG/test_rad_dust_MG.cpp Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 11, 2024
@chongchonghe
Copy link
Contributor Author

This seems fine, but I don't think values of c ^ / c of 0.5 or 0.8 are realistic. I don't think we'd ever run with a value greater than 0.1 . Otherwise, we might as well just use the full speed of light, or give up and use a fully implicit method.

OK. I set chat = 0.1 c in all these tests. Previously I was just testing if the RSLA method is producing results that agree with the analytical ones.

@chongchonghe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me assuming GPU tests pass.

In general, I think it's better to make the test problems as close to our production simulations as we can, unless it's not possible or there's another good reason not to.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2024
@chongchonghe chongchonghe added this pull request to the merge queue Dec 11, 2024
Merged via the queue into development with commit 83150cf Dec 11, 2024
23 checks passed
@chongchonghe chongchonghe deleted the chong/set_dust_and_PE_to_RSLA branch December 13, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants