Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Metal Advection Problem" #710

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Revert "Metal Advection Problem" #710

merged 1 commit into from
Aug 9, 2024

Conversation

BenWibking
Copy link
Collaborator

Reverts #704.

It wasn't quite ready yet.

@BenWibking BenWibking requested a review from aditivijayan August 8, 2024 22:37
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 8, 2024
aditivijayan
aditivijayan reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@aditivijayan aditivijayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run a test on Setonix and open a PR again.

@BenWibking BenWibking enabled auto-merge August 8, 2024 22:40
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2024
@BenWibking BenWibking added this pull request to the merge queue Aug 8, 2024
Merged via the queue into development with commit c5c6a87 Aug 9, 2024
19 checks passed
@BenWibking BenWibking deleted the revert-704-Setonix-GasGrav branch August 10, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditivijayan aditivijayan aditivijayan approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWibking @aditivijayan