Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Setonix compiler version #709

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

BenWibking
Copy link
Collaborator

Description

This uses ROCm version 5.5.3, which is actually able to compile the metal advection problem.

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Setonix labels Aug 8, 2024
@BenWibking BenWibking enabled auto-merge August 8, 2024 20:41
@BenWibking BenWibking added this pull request to the merge queue Aug 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
Merged via the queue into development with commit 58eb97e Aug 9, 2024
19 checks passed
@BenWibking BenWibking deleted the BenWibking/fix-setonix-settings branch August 10, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer Setonix size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants