Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citations #690

Merged
merged 25 commits into from
Jul 30, 2024
Merged

Update citations #690

merged 25 commits into from
Jul 30, 2024

Conversation

chongchonghe
Copy link
Contributor

@chongchonghe chongchonghe commented Jul 30, 2024

Description

Update citation for the newly published multigroup RHD paper on arxiv.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

chongchonghe and others added 23 commits July 25, 2024 22:48
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jul 30, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jul 30, 2024
@chongchonghe chongchonghe requested a review from BenWibking July 30, 2024 04:49
@BenWibking
Copy link
Collaborator

I think it's a bit repetitive to have the citation repeated three times:
image

Maybe you could create a separate bibliography block for each bullet point?

@chongchonghe
Copy link
Contributor Author

chongchonghe commented Jul 30, 2024

I think it's a bit repetitive to have the citation repeated three times: image

Maybe you could create a separate bibliography block for each bullet point?

I tried, but you'll get two bibliographies with the same citation key, since they have the same authors and year. I don't know a way to get away with it, so that's the best way I found that is concise and also displays the full article titles in the same page.

If two times instead of three times is better, I can replace cite:ts: with cite:, which would remove the first occurrence of the names.

Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think this is better.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2024
@BenWibking BenWibking enabled auto-merge July 30, 2024 15:32
@BenWibking BenWibking added this pull request to the merge queue Jul 30, 2024
Merged via the queue into development with commit 725c343 Jul 30, 2024
19 checks passed
@chongchonghe chongchonghe deleted the chongchong/update-citations branch July 31, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants