-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPL opacity models #678
Merged
Merged
PPL opacity models #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined three models: piecewise_constant_opacity, PPL_opacity_fixed_slope_spectrum, PPL_opacity_full_spectrum
Yes, I know. I'm working on it. |
7 tasks
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
🍻 All tests passed! |
markkrumholz
approved these changes
Jul 24, 2024
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main updates:
Defined three opacity models described in Paper III: piecewise constant (
piecewise_constant_opacity
), piecewise powerlaw with fixed slope (PPL_opacity_fixed_slope_spectrum
), piecewise powerlaw with full spectrum fitting (PPL_opacity_full_spectrum
).Added tests for each of these methods.
PPL_opacity_full_spectrum
) to deal with frequency-dependent velocities within an energy bin.PPL_opacity_fixed_slope_spectrum
method provides the same result as the single-group method.PPL_opacity_full_spectrum
in the special case of constant opacity.More updates:
ComputePlanckOpacityTempDerivative
ComputeDiffusionFluxMeanOpacity
and removed the calculation of component-specific flux-mean opacity. See Paper III.ComputeBinCenterOpacity
to use whenopacity_model_ == OpacityModel::PPL_opacity_full_spectrum
anduse_diffuse_flux_mean_opacity = false
.Erad0Vec
butEradVec_guess
should be used.alpha_E
andalpha_B
aftermax_ite_to_update_alpha_E
steps in the Newton iteration.reconstructionOrder_=3
in the RadTube and RadhydroShockMultigroup tests to avoid "erroneous arithmetic" error after using-DCMAKE_CXX_FLAGS=-ffp-exception-behavior=strict
.Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.