Fix radiation transport error in Y and Z directions. #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…m/quokka-astro/quokka into chongchong/fix-2D-radiation-issue
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
for more information, see https://pre-commit.ci
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BenWibking
reviewed
May 27, 2024
…m/quokka-astro/quokka into chongchong/fix-2D-radiation-issue
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BenWibking
reviewed
May 28, 2024
|
Ok, the avatargpu tests are running now: https://dev.azure.com/quokka-code/quokka-CI/_build/results?buildId=10538&view=logs&j=655dacad-9e02-5f72-e0cf-043ebfb7cecc |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
OK. All tests passed. Only have to check if the SphericalCollapse test still run on time on nvcc after setting max_time back to 0.05. |
BenWibking
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug #632 . This is a dumb mistake I made on using
AMREX_D_TERMinAddFluxesRK2, causing a wrong calculation of the HLL flux in 2D/3D cases. The mistake was introduced in the "Use IMEX PD-ARS ..." commit (78c5970) 6 months ago. Because of this mistake, all 2D/3D simulations since then with non-zero y/z-component radiation fluxes are wrong.To avoid mistakes like this in the future, I added a new test of radiation streaming in the Y direction. I plan to add a better test (say, the RadShock test) in both Y and Z direction, with the following grid configuration: [4, 128, 4] and [4, 4, 128]. Or, alternatively, we should have a non-trivial 3D test with an exact solution.
Related issues
Fixed #632
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.