Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU problems in pulse_MG.cpp #629

Merged
merged 3 commits into from
May 15, 2024

Conversation

chongchonghe
Copy link
Contributor

@chongchonghe chongchonghe commented May 14, 2024

Description

I discovered some GPU-related issues in radhydro_pulse_MG.cpp and fixed it. In the previous PR, I turned if off for 3D problems because it is too expensive. As a result, it didn't get to compile and run on nvcc or ROCm. I fixed some first-capture and undefined on device issues and turned this test (and radhydro_pulse_MG_int.cpp) on. I set max_timesteps=10 in these tests in order to let them finish fast. We are not comparing with exact solutions any way (because there isn't one), so it's okay to run only a small number of time steps and show that the architecture is working. The accuracy of the multigroup implementation is tested by hand, and I will include it in a planned nightly unit test.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@chongchonghe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@chongchonghe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@chongchonghe chongchonghe requested a review from BenWibking May 14, 2024 15:14
@chongchonghe chongchonghe enabled auto-merge May 15, 2024 00:12
@chongchonghe chongchonghe added this pull request to the merge queue May 15, 2024
Merged via the queue into development with commit 314debb May 15, 2024
21 checks passed
@chongchonghe chongchonghe deleted the chongchong/kappa-int-v8.2.3 branch September 27, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants