Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered some GPU-related issues in radhydro_pulse_MG.cpp and fixed it. In the previous PR, I turned if off for 3D problems because it is too expensive. As a result, it didn't get to compile and run on nvcc or ROCm. I fixed some first-capture and undefined on device issues and turned this test (and radhydro_pulse_MG_int.cpp) on. I set
max_timesteps=10
in these tests in order to let them finish fast. We are not comparing with exact solutions any way (because there isn't one), so it's okay to run only a small number of time steps and show that the architecture is working. The accuracy of the multigroup implementation is tested by hand, and I will include it in a planned nightly unit test.Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.